Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Deploy a NFT" with remix tutorial #340

Merged
merged 17 commits into from
Feb 5, 2025
Merged

Add "Deploy a NFT" with remix tutorial #340

merged 17 commits into from
Feb 5, 2025

Conversation

nhussein11
Copy link
Collaborator

This PR adds a tutorial to deploy a NFT using polkadot remix IDE

@nhussein11 nhussein11 added B0 - Needs Review Pull request is ready for review C1 - Medium Medium priority task A0 - New Content Pull request contains new content pages labels Jan 29, 2025
@nhussein11 nhussein11 requested review from 0xLucca and a team January 29, 2025 14:19
@nhussein11 nhussein11 requested a review from a team as a code owner January 29, 2025 14:19
0xLucca
0xLucca reviewed Jan 31, 2025
View reviewed changes
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
@nhussein11 nhussein11 requested a review from 0xLucca January 31, 2025 15:23
0xLucca
0xLucca approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just fix this minor things

tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
eshaben
eshaben reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some minor stuff 🙂

tutorials/smart-contracts/.pages Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
tutorials/smart-contracts/deploy-nft.md Outdated Show resolved Hide resolved
@nhussein11 nhussein11 requested a review from eshaben February 3, 2025 12:24
eshaben
eshaben approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Feb 3, 2025
@eshaben eshaben merged commit f3e54c2 into staging-ah-smart-contracts Feb 5, 2025
6 checks passed
@eshaben eshaben deleted the 337-create-a-deploy-a-nft-with-remix-tutorial branch February 5, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshaben eshaben eshaben approved these changes

@0xLucca 0xLucca 0xLucca approved these changes

Assignees
No one assigned
Labels
A0 - New Content Pull request contains new content pages B1 - Ready to Merge Pull request is ready to be merged C1 - Medium Medium priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nhussein11 @eshaben @0xLucca